Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16867 object: fix error handling of ds_cpd_handle_one() #15565

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

wangshilong
Copy link
Contributor

@wangshilong wangshilong commented Dec 6, 2024

ABT_eventual_wait() might access freed eventual in error case.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented Dec 6, 2024

Ticket title is 'Potential NULL pointer access in ds_cpd_handle_one'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-16867

ABT_eventual_wait() might access freed eventual in error case.

Required-githooks: true
Signed-off-by: Wang Shilong <[email protected]>
@wangshilong wangshilong force-pushed the shilongw/fix_cpd_handle branch from af6ff96 to 330ed65 Compare December 10, 2024 01:58
@wangshilong wangshilong changed the title DAOS-0000 object: fix ds_cpd_handle_one() DAOS-16867 object: fix error handling of ds_cpd_handle_one() Dec 10, 2024
@wangshilong wangshilong marked this pull request as ready for review December 10, 2024 02:18
@wangshilong wangshilong requested review from a team as code owners December 10, 2024 02:18
@wangshilong wangshilong requested review from Nasf-Fan and liuxuezhao and removed request for a team December 10, 2024 02:18
@wangshilong wangshilong requested a review from a team December 18, 2024 01:29
@NiuYawei NiuYawei merged commit f07e5da into master Dec 18, 2024
58 checks passed
@NiuYawei NiuYawei deleted the shilongw/fix_cpd_handle branch December 18, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants